Perform polish of miscellaneous Settings UI bugs #9126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carlos-zamora
commented
Feb 11, 2021
•
carlos-zamora
commented
- 0b0dbdf Makes the browse buttons center vertically aligned
- This is now made possible by Represent inheritance in Settings UI #8919. The "center" used to include the height of the header. Now that it's separated, the center is solely calculated to be the text box.
- Closes Polish Settings UI: Profile page #8764
- 0288f06 Fix keyboard navigation focus for color schemes rename button
- Enter/Esc when in the scheme renamer now focuses the combo box
- Keyboard-invoking accept/cancel button focuses the rename button
- References Polish Settings UI: Color Scheme page #8765 and Polish Settings UI: Keyboard navigation (w/ tab key) #8768
- d5ef552 Cyclical tab navigation
- now, if you try to tab past the save button, you cycle back to the beginning of the navigation view
- this is consistent with the xaml controls gallery
- References Polish Settings UI: Keyboard navigation (w/ tab key) #8768
- a613b08 AutomationProperties for Save, Reset, and open json buttons
- References Add automation properties to Settings UI #8899
ghost
added
Area-Settings UI
This comment has been minimized.
This comment has been minimized.
6 tasks
zadjii-msft
approved these changes
Feb 17, 2021
ghost
requested review from
DHowett
approved these changes
Feb 17, 2021
carlos-zamora
added
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.